Repository navigation
Conversation
repository_ctx.path(label) makes the repo containing the file available on disk, which isn't needed to read a template. With Bazel's remote repo contents cache, this downloads every file of rules_fuzzing whenever the OSS-Fuzz repo is fetched, which happens in every build since it is a local repo.
fmeum
marked this pull request as ready for review
October 19, 2026 14:01
fmeum
enabled auto-merge (squash)
October 19, 2026 14:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
oss_fuzz_repositoryresolved its two template labels withrepository_ctx.pathbefore passing them torepository_ctx.template, which accepts labels directly. Resolving a label to a path makes the repo containing the file available on disk. With Bazel's--experimental_remote_repo_contents_cache,rules_fuzzingis otherwise only kept in memory, so this downloads all of its files whenever@rules_fuzzing_oss_fuzzis fetched. Since that is a local repo, this happens in every build that loads it (bazelbuild/bazel#31005). With bazelbuild/bazel#31493,template(label)only fetches the template itself. In Bazel's own CI with the cache enabled (bazelbuild/bazel#31755), thepathcall took about 0.5 s per job.The generated
BUILDandinstrum.bzlfiles are identical before and after this change.