Repository navigation
Generate showcase video in CI and publish an inline README player - #21
Merged
Merged
Conversation
baol
marked this pull request as ready for review
October 16, 2026 10:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate a silent 720p, 30 fps H.264 showcase video from the actual renderer at fixed frame steps. CI compresses and verifies it below GitHub's attachment limit, then publishes an attachment URL into a marked README section on master. Video binaries stay outside Git history; feature-branch runs produce an Actions artifact only.
Publication requires the repository secret DEMO_MEDIA_TOKEN: a user token scoped to this repository with Contents and Issues write access. GitHub's attachment endpoint rejects the built-in Actions installation token. The workflow checks source freshness and excludes README-only updates to prevent recording loops. The initial README player appears after the first successful master publication.
Validation: all 199 tests pass on the rebased commit; 198 are below 500 ms and the recording integration case takes 537 ms (within the exceptional one-second budget). The Showcase video CI job succeeded and produced a roughly 6.9 MB artifact: https://github.com/baol/pdfcube/actions/runs/38881279765. Live attachment publication remains unverified until the secret is configured and the workflow runs on master.