Repository navigation
Usermap fixes, pak changes for usermaps - #705
Merged
Merged
Conversation
mjkzy
requested changes
Oct 5, 2026
mjkzy
left a comment
mjkzy
left a comment
Collaborator
There was a problem hiding this comment.
few changes, LGTM otherwise
Comment on lines
+521
to
+523
| const auto* name = *reinterpret_cast<const char**>(asset); | ||
| const auto size = *reinterpret_cast<std::uint32_t*>(asset + 8); | ||
| const auto* data = *reinterpret_cast<std::uint8_t**>(asset + 16); |
Collaborator
There was a problem hiding this comment.
i think this is clanker slop right here - i think its trying to use a asset struct that has name at 0 bytes, size at 8, and data at 16, and maybe x64-zt contains that type. can we show that struct nicely instead?
Contributor
Author
There was a problem hiding this comment.
was clanker slop, corrected it with structs
| console::error("Physics asset \"%s\" skipped: %s (size %u, data %p)\n", name ? name : "?", reason, size, data); | ||
| return; | ||
| } | ||
| physics_asset_post_load_hook.invoke<void>(asset); |
Collaborator
There was a problem hiding this comment.
prefer spacing/whitespace for readability
| // Don't fatal on certain missing zones | ||
| db_is_patch_hook.create(0x1403BC580, db_is_patch_stub); | ||
| physics_asset_post_load_hook.create(0x140572690, physics_asset_post_load_stub); | ||
| // Don't load extra zones with loadzone |
Collaborator
|
much better my friend |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
load usermap language zones
name custom image paks after the loading zone
skip physics assets with invalid havok data