Repository navigation
add usermaps support - #701
Merged
Merged
Conversation
Divity
commented
Oct 2, 2026
Divity
commented
Contributor
- load usermaps// fastfiles, pak and sabl/sabs files
- parse usermaps//.arena into the map list, cp_ maps under CP
- load _art.ff at boot for map select images and posters
- group map select into stock and custom sections
- set CP frontend posters for usermaps
- hash, compare and download usermap files when joining a party
- load custom_scripts/frontend/ scripts in the frontend
- load usermaps/<map>/ fastfiles, pak and sabl/sabs files - parse usermaps/<map>/<map>.arena into the map list, cp_ maps under CP - load <map>_art.ff at boot for map select images and posters - group map select into stock and custom sections - set CP frontend posters for usermaps - hash, compare and download usermap files when joining a party - load custom_scripts/frontend/ scripts in the frontend
- serve usermap files by their own name so map preloads find them - grow the CP map list with the number of installed usermaps
mjkzy
requested changes
Oct 4, 2026
mjkzy
left a comment
mjkzy
left a comment
Collaborator
There was a problem hiding this comment.
just a few changes, looks fine otherwise
|
|
||
| watch_players() | ||
| { | ||
| for (;;) |
Collaborator
There was a problem hiding this comment.
make sure we are ending this thread with level endon game_ended
|
|
||
| usermap_poster_watcher() | ||
| { | ||
| self endon( "disconnect" ); |
| return type(name) == "string" and io.fileexists("usermaps/" .. name .. "/" .. name .. ".ff") | ||
| end | ||
|
|
||
| local GetPlayerDataEx = Engine.GetPlayerDataEx |
Collaborator
There was a problem hiding this comment.
nit pick: maybe prefer adding _og/_stub suffix for readability
| local GetPlayerDataEx = Engine.GetPlayerDataEx | ||
| Engine.GetPlayerDataEx = function(...) | ||
| for _, arg in ipairs({...}) do | ||
| if is_usermap(arg) then |
Collaborator
There was a problem hiding this comment.
why do we do this? are usermaps causing weird errors with player data? this feels hacky
Contributor
Author
There was a problem hiding this comment.
sorry it was just overdone, only the leaderboard data needs 0d, just because custom maps have no leaderbaord and ican cause lua errors to throw, will correct shortly
…r data hook to leaderboard lookups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.