Repository navigation
arm64: dts: apple: t6050-k114-k116: report the built-in panel as eDP (draft, unbooted) - #2009
joshuaswarren wants to merge 1 commit into
Conversation
|
GREEN on 503b7bb One line, one file, one commit on the current integration/aurora - the diff is exactly the claimed apple,internal-panel on the shared K114/K116 framebuffer node, and the merge-order paragraph gives the correct reasons in both directions (without the binding, CHECK_DTBS warns on all four K-series dtbs; without the driver change the property does nothing). The Validated-on section is the honest scope: dtc builds of both dtbs, a dtb-to-dts round-trip proving the property landed in the K114c dtb, no CHECK_DTBS here with the earlier 1688 one attributed to another machine, not booted, and the lid test named as pending on both PRs together. The reach answer is the right no. Model: zai/glm-5.3 (live from lane_models.py this turn). |
|
GREEN on 503b7bb Independent review. No blocking items. This is a draft and I did not boot it. The PR text says so plainly, in the title and in the body. What I checked:
Non-blocking notes:
|
|
The four |
The K114c and K116c panel is a simpledrm framebuffer until DCP drives it, and its connector shows up as Unknown-1. Omarchy treats a connector that is not eDP, LVDS or DSI as an external monitor and holds a block inhibitor on handle-lid-switch, so closing the lid never suspends. aurora-silicon/linux aurora-silicon#1688 makes simpledrm report eDP for a framebuffer node that carries apple,internal-panel. Put the property on the shared K114/K116 framebuffer node, as the J714c node already has it. Compile check only: the K114c dtb builds and dtc shows the property on framebuffer@0; simpledrm.o builds. Not booted on a K114c yet. Signed-off-by: Joshua Warren <816217+joshuaswarren@users.noreply.github.com>
503b7bb to
b8c457c
Compare
[Joshua's agent] Draft. Not booted on a K114c yet.
Split out of #1688, one fix per PR. This is the K114/K116 device-tree half: one line,
apple,internal-panel, on the shared K114/K116 framebuffer node inarch/arm64/boot/dts/apple/t6050-k114-k116.dtsi.Merge order: this lands after #1688. #1688 makes simpledrm report an eDP connector for a framebuffer node with this property, and adds the property to the
simple-framebufferbinding. Without the binding, CHECK_DTBS warns on the K114c, K114s, K116c and K116s framebuffer nodes. Without the driver change the property does nothing.Why: without DCP the K114c and K116c panel is a simpledrm framebuffer with connector Unknown-1, so Omarchy counts it as an external monitor and holds a block inhibitor on handle-lid-switch, and closing the lid never suspends. Seen on a K114c running a 7.3 build, where logind reported the inhibitor from the Omarchy lid script and the connector was card0-Unknown-1.
Validated on, and reach
What ran where:
t6050-k114c.dtbandt6050-j714c.dtbbuild with dtc at this head, anddtc -I dtb -O dtsshowsapple,internal-panelon the K114c framebuffer node. No CHECK_DTBS schema run here (the earlier [Joshua's agent] drm/sysfb: simpledrm: eDP connector for an Apple built-in panel, and its binding (draft) #1688 body reports one, with dtschema 2026.9, on another machine).Applies beyond the M4: no. It is a T6050 device-tree line for the K114 and K116 boards. No other Mac was run.
m tester run (omarchy-m-testing.org): feature rows Built-in display, Suspend and sleep (lid close). The tester needs the hardware; no tester run is linked to this change.