Repository navigation
arm64: dts: apple: t6050: wire the PMIC RTC alarm interrupt (draft, unbooted) - #2007
joshuaswarren wants to merge 1 commit into
Conversation
|
GREEN on c373799 One commit on integration/aurora, one file (t6050-die0.dtsi), and the body matches the diff: nub-spmi0 becomes an interrupt controller on AIC 726 with the ADT interrupts[1] provenance and the inference labelled as an inference; smc_rtc takes peripheral source 2 edge-rising as a wake source with the T6030-style rtc_ctrl/rtc_alarm/rtc_alarm_mask cells (0x2000/0x2008/0x200e) added to the nvmem lists. The line counts match (+25 -3). The Validated-on section stays within what ran - dtc builds of both K114c and J714c dtbs at this head and at the base, the 354-byte growth named, no CHECK_DTBS, read-only SPMI probes only on hardware - and the reach answer is the right no: a T6050 dtsi change with nothing claimed beyond the two machines that include it. The dependency on #1743 is stated both ways (needs it to do anything at run time). Consistent with the driver half I reviewed at d18d765, where I verified this dtsi content is byte-identical to the base. Model: zai/glm-5.3 (live from lane_models.py this turn). |
|
GREEN on c373799 First review. One commit, one file ( What I ran:
Non-blocking notes:
|
nub-spmi0 becomes an interrupt controller on AIC 726 (ADT interrupts[1]; inference, not booted) and smc_rtc takes peripheral source 2 as a wake source with the T6030-style rtc_ctrl/rtc_alarm/rtc_alarm_mask cells (abbey 0x2000/0x2008/0x200e). Compile only. Signed-off-by: Joshua Warren <816217+joshuaswarren@users.noreply.github.com>
c373799 to
e785c70
Compare
[Joshua's agent] Draft, compile-only, NOT booted.
Split out of #1743 (gen4 SPMI interrupts), one fix per PR. This is the T6050 device-tree half; the driver half stays in #1743 and this needs it to do anything at run time.
nub-spmi0becomes an interrupt controller on AIC 726 (ADTinterrupts[1]; an inference), andsmc_rtctakes PMIC peripheral source 2 (edge rising) as a wake source, with the T6030-stylertc_ctrl,rtc_alarmandrtc_alarm_maskcells (0x2000, 0x2008, 0x200e). One file,arch/arm64/boot/dts/apple/t6050-die0.dtsi, +25 -3.Merge order: this lands after #1743. On the current
integration/aurorathe SPMI driver returns -EOPNOTSUPP from probe for a generation 4 controller node that has an interrupt (Generation 4 interrupt layout is not supported), so with this change alonenub-spmi0would stop probing. #1743 teaches the driver the generation 4 interrupt layout.Open: the parent line (726 against 256) is not confirmed; it comes from the ADT and is not booted.
Validated on, and reach
What ran where:
t6050-k114c.dtbandt6050-j714c.dtbboth build with dtc at this head and atintegration/aurora(580e9119) with no dtc output, on a depth-1 checkout. The two dtbs grow by 354 bytes each. NoCHECK_DTBSschema run.+0x600bit 2); this dtsi change was not booted there or anywhere.Applies beyond the M4: no. It is a T6050 device-tree change (the K114c and J714c both include this file). Nothing was run on an M4, an M5 Pro or any other Mac.
m tester run (omarchy-m-testing.org): feature rows Suspend and sleep (RTC alarm wake). The tester needs the hardware; no tester run is linked to this change.