Repository navigation
Conversation
This commit adds the standard Tailwind focus-visible styling to the tab_link button inside DeploymentComponents to ensure it is keyboard accessible and consistent with other components in the design system. Co-authored-by: aryaminus <16350823+aryaminus@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This commit adds the standard Tailwind focus-visible styling to the tab_link button inside DeploymentComponents to ensure it is keyboard accessible and consistent with other components in the design system. Additionally, this commit resolves SQLite lock contention issues in subprocess-based tests by properly isolating the DB and bypassing the Ecto Sandbox, and fixes a compiler warning regarding an unused alias. Co-authored-by: aryaminus <16350823+aryaminus@users.noreply.github.com>
This commit adds the standard Tailwind focus-visible styling to the tab_link button inside DeploymentComponents to ensure it is keyboard accessible and consistent with other components in the design system. Additionally, this commit resolves SQLite lock contention issues in subprocess-based tests by properly isolating the DB and bypassing the Ecto Sandbox, and fixes a compiler warning regarding an unused alias. Co-authored-by: aryaminus <16350823+aryaminus@users.noreply.github.com>
This commit adds the standard Tailwind focus-visible styling to the tab_link button inside DeploymentComponents to ensure it is keyboard accessible and consistent with other components in the design system. Additionally, this commit resolves SQLite lock contention issues in subprocess-based tests by properly isolating the DB and bypassing the Ecto Sandbox, and cleans up several compiler warnings (unused variables/aliases) blocking the CI build. Co-authored-by: aryaminus <16350823+aryaminus@users.noreply.github.com>
What:
Added
focus-visiblestyling classes to thetab_link<button>inControlKeelWeb.DeploymentComponents.Why:
The deployment tab buttons were missing keyboard focus indicators. This made it difficult for users relying on keyboard navigation to know which tab they were currently focused on.
Before/After:
Tabkey provided no visual feedback.Tabkey now displays the standard primary-colored focus ring, matching the rest of the application's interactive elements.Accessibility:
focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-primary focus-visible:ring-offset-2 focus-visible:ring-offset-background).PR created automatically by Jules for task 13968637621510585439 started by @aryaminus