Repository navigation
Fix deadlock when an entry group's state channel is full - #558
Merged
Merged
Conversation
ldddns did not read StateChangeChannel. The channel holds 10 state changes, and each restart of a container adds about three. When the channel is full, go-avahi v1.0.1 blocks while it holds the server lock. At the next new container, ldddns then stops and ignores SIGTERM. Bump go-avahi to v1.1.0, which sends signals without the lock. Read the state channel of each entry group, and log collisions and failures as warnings. Assisted-by: Claude Signed-off-by: Achton Smidt Winther <achton@reload.dk>
This was referenced Oct 19, 2026
arnested
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ldddns did not read go-avahi's
StateChangeChannel. The channel holds 10 state changes, and each restart of a container adds about three. When the channel of one entry group is full, go-avahi v1.0.1 blocks while it holds the server lock. At the next new container, ldddns then stops. It does not publish or remove names, and it ignores SIGTERM until systemd kills it. This is probably the deadlock that #480 added logging for.This PR bumps go-avahi to v1.1.0, which sends signals without the lock. It also reads the state channel of each entry group and logs collisions and failures as warnings.
To reproduce the problem on
main:VIRTUAL_HOST.docker restarton the container three times.