Repository navigation
Access Keys: a key's person takes the name of their last signed-in write (0.1.12) - #10
Merged
Merged
Conversation
…ite (0.1.12) A key assertion carries no name, so key writes and /me showed the subject id. Resolve the display name from the workspace's activity log; fall back to the subject before any signed-in write.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A key assertion carries no name and is not forwarded to Directory, so issues, comments and
/mewritten through a key showed the subject UUID.What
store.KnownName: the display name most recently recorded for the subject by a signed-in write (activity log, excluding rows whose name is the subject itself). Key requests use it for the actor; before any signed-in write the name stays the subject id.tracker_activity (actor_sub, created_at DESC)for that lookup.design/API.md§ Access Keys updated; release 0.1.12.Rows already stored with the UUID are not rewritten.
Verification
go vet ./cmd/...;go test -count=1 ./cmd/...against a disposable Postgres 17: all five packages passed, including the extended key test and the migration-from-v0.1.0 test. CI skips the database tests.