Repository navigation
IGNITE-29191 Fix local IndexQuery ignoring setLimit() - #13735
Open
rezataroosheh wants to merge 1 commit into
Open
rezataroosheh wants to merge 1 commit into
rezataroosheh wants to merge 1 commit into
Conversation
rezataroosheh
marked this pull request as ready for review
October 22, 2026 22:07
rezataroosheh
force-pushed
the
IGNITE-29191
branch
from
October 23, 2026 06:19
dc8143b to
0457ebb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A local
IndexQuery(setLocal(true)) now respectssetLimit(): it returns at mostlimitentries. Queries without a limit are not affected.Why
The limit was applied only on the distributed path, in the query future on the reducer side. The local path (
GridCacheQueryManager#indexQueryLocal) never read it, so a local query withsetLimit(3)returned every matching entry. It was reported on the dev list.Tests
New
IndexQueryLimitTest#testLocalQueryLimit: a local query withsetLimit(3)returns 3 entries. It fails without the fix (it returns all 10000).The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see tabPR Checkat TC.Bot - Instance 1 or TC.Bot - Instance 2)Notes
If you need any help, please email dev@ignite.apache.org or ask any advice on https://the-asf.slack.com #ignite channel.