Repository navigation
fix: reject stale and foreign link instances on removal - #55
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing a stale link instance can delete a newer link with the same ID from the graph's global map while leaving its adjacency sets intact. A link from another graph with the same ID has the same effect.
Require the stored link to be the exact instance passed to removeLink(), so nonexistent instances return false without mutation or change events. Rebuilt the tracked distributions to apply the fix to the CommonJS entry point as well.
Eight synthetic regression cases cover stale and foreign references in ordinary and multigraph modes through both source and CommonJS entry points, including adjacency consistency and event delivery. All eight fail before the fix and pass after it.
Validation on Node 24.14.1: npm run build and the full Vitest coverage run pass (5 files, 51 tests). index.js has 99.39% statement/line coverage, 97.91% branch coverage and 100% function coverage; overall coverage includes unexecuted performance examples. git diff --check passes. The CI Node 18/20 matrix was not run locally. No real graph datasets or external services were used.