Repository navigation
Import Rust authorization lock SDK support - #12
Merged
Merged
Conversation
edo-chan
changed the base branch from
codex/refresh-solana-protocol-sdks
to
main
October 29, 2026 20:18
edo-chan
marked this pull request as ready for review
October 29, 2026 20:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Import the Rust protocol SDK portion of swig-wallet#226 and swig-wallet#240 into
solana/rust/. This carries interface builders, client-role helpers, high-level wallet methods, and authorization-lock tests. CLI changes remain inswig-wallet.The on-chain dependencies and IDL fixture are pinned to
swig-wallet@c5edad67f82958f7fb282634ad91c752602e76ca, the source head of #240. The import supports Ed25519, secp256k1, secp256r1, and session-key lock operations; ProgramExec high-level lock helpers remain explicitly unsupported. Revisit the pin after the on-chain PR merges, before release.The original CLI review comment asks for a transaction-correlated lock ID. The pinned program does not return one, so this SDK cannot guarantee it from a later account read; the CLI and program follow-up remains in
swig-wallet.Validation
Base
25818643ffc0b901be7cef1aa6ee04e67fe7db3e; head9dfc555.cargo check --workspace --locked: pass.cargo fmt --all -- --check: pass.cargo clippy --workspace --all-targets --locked: pass with existing warnings.cargo test --workspace --locked: pass.cargo test --workspace --locked --features rust_sdk_test: 151 SDK tests and 7 interface tests passed against the pinned program fixture.git diff --check: pass.The repository CI currently covers EVM; Solana checks above ran locally on this head. Solana CI and publishing remain separate follow-ups.