Repository navigation
fix: drop the fence language tag when a full rewrite falls back to any code block - #544
Merged
codelion merged 1 commit intoOct 25, 2026
Conversation
…y code block When the response's fence language doesn't match the configured one (```py, ```python3, ```js for javascript, ...), parse_full_rewrite fell back to a pattern that captured everything after the backticks, so the tag became the first line of the extracted program.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a full-rewrite response's fence language doesn't match
config.language,parse_full_rewritefalls back to```(.*?)```, which keeps the tag. So```py,```python3,```Python(or```jswithlanguage: javascript,```rswithrust) put the tag on the first line of the extracted program, and evaluation fails with aNameError/syntax error.The fallback now skips a single-word tag on the fence line, with the same trailing-whitespace and CRLF handling as the language-specific pattern. Fences without a tag, and the one-line
```x = 1```form, are parsed as before.Tests: new
test_parse_full_rewrite_other_language_tag(LF/CRLF, several tags); all 9 subtests fail on main. Full unit suite 881 → 882 passed, 2 skipped. Black passes.