Skip to content

Use each COCO stuff annotation bounding box - #3272

Open
dajiaohuang wants to merge 1 commit into
activeloopai:mainfrom
dajiaohuang:fix-coco-stuff-bbox-3267
Open

dajiaohuang wants to merge 1 commit into
activeloopai:mainfrom
dajiaohuang:fix-coco-stuff-bbox-3267

Conversation

@dajiaohuang

@dajiaohuang dajiaohuang commented Oct 7, 2026 •

Copy link
Copy Markdown

Impact: Bug fix. ### Description: Fixes #3267. Remove the unrelated instance annotation argument and populate every stuff box from its matching stuff annotation. Validation: git diff --check passed. No tests or builds were run per assignment. ### Things to be aware of: The fix is scoped to the reported call path and preserves the existing API. ### Things to worry about: Tests and runtime validation were not run. ### Additional Context: No additional dependency or migration changes.

Summary by CodeRabbit

  • Bug Fixes
    • Corrected bounding boxes for COCO stuff annotations during ingestion.

@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f228f42e-5d25-47b6-8543-59676009c014
📥 Commits

Reviewing files that changed from the base of the PR and between f432041 and 903521d.

📒 Files selected for processing (1)
  • python/deeplake/ingestion/coco/ingest_coco.py

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

COCO stuff ingestion now reads each stuff annotation’s bounding box from that annotation. The helper no longer accepts the unused instance annotation argument, and its caller uses the updated argument list.

Changes

COCO stuff annotation ingestion

Layer / File(s) Summary
Update stuff annotation helper and caller
python/deeplake/ingestion/coco/ingest_coco.py
get_stuff_group_data no longer accepts the unused ann argument. It reads the bounding box from ann_stuff, and ingest_columns calls it with the updated arguments.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to 90352

The ingestion path now uses each stuff annotation’s own bounding box and no longer depends on an instance annotation being present. No actionable merge-blocking risk is established.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description covers all required sections: impact, change details, technical considerations, concerns, and additional context. It identifies issue #3267 and states that tests and builds were not ru…
Title check ✅ Passed The title clearly and concisely describes the main change: using each COCO stuff annotation bounding box.
Linked Issues check ✅ Passed For [#3267], the PR removes the unrelated ann parameter from get_stuff_group_data, reads the bounding box from each ann_stuff, and updates ingest_columns to use the new call. This implements t…
Out of Scope Changes check ✅ Passed The reported change is limited to python/deeplake/ingestion/coco/ingest_coco.py and contains three additions and three deletions. The change directly supports [#3267]. It does not include the separa…
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks each stuff box with care,
No borrowed instance bounds are there.
The helper takes the arguments it needs,
And passes the right box through the reeds.
Hop, hop—the annotations align!

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] COCO stuff ingestion uses instance bbox for stuff annotations

1 participant