Repository navigation
Conversation
ilikesn0w
force-pushed
the
OpenCanopySdCard
branch
4 times, most recently
from
November 8, 2026 07:53
50b4c2b to
a3babc6
Compare
ilikesn0w
commented
Nov 8, 2026
Comment on lines
+439
to
+447
| if ( (DevicePathType (DevicePathWalker) == MESSAGING_DEVICE_PATH) | ||
| && (DevicePathSubType (DevicePathWalker) == MSG_VENDOR_DP) | ||
| && (DevicePathNodeLength (DevicePathWalker) >= sizeof (VENDOR_DEFINED_DEVICE_PATH))) | ||
| { | ||
| VendorNode = (VENDOR_DEFINED_DEVICE_PATH *)DevicePathWalker; | ||
| if (CompareGuid (&gAppleSdCardVendorDevicePathGuid, &VendorNode->Guid)) { | ||
| return TRUE; | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Used some code from OcGetNextLoadOptionDevicePath here.
ilikesn0w
force-pushed
the
OpenCanopySdCard
branch
from
November 11, 2026 19:31
a3babc6 to
ee56104
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added SD card icon support to OpenCanopy.
Regarding the changes to
GuiClickableIsHit: Some icons may have transparent areas (for example, hole in the OpticalDrive or rectangular holes on the top sides of the SD card icon), and because of this, those areas cannot be pressed, my changes fixes this problem. Apple does this as well.Linked PR: acidanthera/OcBinaryData#17