Skip to content

CURA-13374 Fix translations context/place - #1064

Merged
HellAholic merged 1 commit into
5.14from
CURA-13374_missing-translations
Oct 26, 2026
Merged

HellAholic merged 1 commit into
5.14from
CURA-13374_missing-translations

Conversation

@wawanbreton

@wawanbreton Erwan MATHIEU (wawanbreton) commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

The "From Disk" label is no more in Uranium but in Cura

Comes with Ultimaker/Cura#21874
CURA-13374

CURA-13374
The "From Disk" label is no more in Uranium but in Cura, and some contexts have changed.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The scoped removal is consistent across the template and locale catalogs, with no remaining consumers or unresolved issues identified.

No open issues 🎉

What changed in this PR

Removes the obsolete “From Disk” translation entry from Uranium, reflecting that the label now belongs to Cura.

Changes:

  • Removes the @menu entry from the translation template.
  • Removes the matching entry from all 17 locale catalogs.
File Description
resources/​i18n/​zh_TW/​uranium.po Removes the Traditional Chinese entry.
resources/​i18n/​zh_CN/​uranium.po Removes the Simplified Chinese entry.
resources/​i18n/​uranium.pot Removes the obsolete template entry.
resources/​i18n/​tr_TR/​uranium.po Removes the Turkish entry.
resources/​i18n/​ru_RU/​uranium.po Removes the Russian entry.
resources/​i18n/​pt_PT/​uranium.po Removes the European Portuguese entry.
resources/​i18n/​pt_BR/​uranium.po Removes the Brazilian Portuguese entry.
resources/​i18n/​pl_PL/​uranium.po Removes the untranslated Polish entry.
resources/​i18n/​nl_NL/​uranium.po Removes the Dutch entry.
resources/​i18n/​ko_KR/​uranium.po Removes the Korean entry.
resources/​i18n/​ja_JP/​uranium.po Removes the Japanese entry.
resources/​i18n/​it_IT/​uranium.po Removes the Italian entry.
resources/​i18n/​hu_HU/​uranium.po Removes the untranslated Hungarian entry.
resources/​i18n/​fr_FR/​uranium.po Removes the French entry.
resources/​i18n/​fi_FI/​uranium.po Removes the untranslated Finnish entry.
resources/​i18n/​es_ES/​uranium.po Removes the Spanish entry.
resources/​i18n/​de_DE/​uranium.po Removes the German entry.
resources/​i18n/​cs_CZ/​uranium.po Removes the Czech entry.

Review effort: Balanced

@HellAholic HellAholic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Test Results

2 404 tests  ±0   2 389 ✅ ±0   21s ⏱️ +4s
    1 suites ±0      15 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 98b9f43. ± Comparison against base commit 537b5d0.

♻️ This comment has been updated with latest results.

@HellAholic
HellAholic merged commit 57054bc into 5.14 Oct 26, 2026
18 checks passed
@HellAholic
HellAholic deleted the CURA-13374_missing-translations branch October 26, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants