Skip to content

[CURA-13375] Type '\n' newlines don't work predictably across translations; use '<br/>' instead. - #1061

Merged
HellAholic merged 1 commit into
5.14from
CURA-13375_fix_newlines_514
Oct 27, 2026
Merged

HellAholic merged 1 commit into
5.14from
CURA-13375_fix_newlines_514

Conversation

@rburema

@rburema R. Burema (rburema) commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

(In QML at least.)

Copilot AI balanced review requested due to automatic review settings October 20, 2026 12:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused change is compatible with the label’s automatic text formatting, with no blocking issues identified.

No open issues 🎉

What changed in this PR

Updates the rename dialog’s explanation spacing to use an HTML line break for more predictable QML rendering across translations.

Changes:

  • Replaces the trailing \n with <br/>.
File Description
UM/​Qt/​qml/​UM/​Preferences/​RenameDialog.qml Uses <br/> after the explanation text.

Review effort: Balanced

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Test Results

2 404 tests  ±0   2 389 ✅ ±0   21s ⏱️ +4s
    1 suites ±0      15 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 4c651d3. ± Comparison against base commit 537b5d0.

♻️ This comment has been updated with latest results.

@HellAholic
HellAholic merged commit bce7302 into 5.14 Oct 27, 2026
18 checks passed
@HellAholic
HellAholic deleted the CURA-13375_fix_newlines_514 branch October 27, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants