Repository navigation
Add scaler API for YCbCr range - #156
Merged
Merged
Conversation
Themaister
approved these changes
Oct 7, 2026
Themaister
left a comment
Owner
There was a problem hiding this comment.
Painful that limited YCbCr needs to be supported, but at least it doesn't have to touch the shaders.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
VideoScaler::set_ycbcr_range()so callers can get limited (narrow) range YCbCr out of the scaler, next to the existingset_ycbcr_chroma_midpoint(). Full range stays the default, so existing output is unchanged.For
VK_SAMPLER_YCBCR_RANGE_ITU_NARROWat bit depth n, the luma row is scaled by219 * 2^(n-8) / (2^n - 1)with offset16 * 2^(n-8) / (2^n - 1), and the chroma rows by224 * 2^(n-8) / (2^n - 1). The chroma midpoint still comes fromset_ycbcr_chroma_midpoint(). Only the UBO matrix changes, so the scaler shader (and pyrowave's pre-generatedslangmosh_scaler.hpp) is untouched.Needed for Themaister/pyrowave#25 and Themaister/pyrowave#24.