Repository navigation
fix(zip): allow set folder date for fix #590 - #610
Merged
Merged
Conversation
Remove the public folder() options API from the community fix; folder date inheritance belongs in the internal fileAdd to folderAdd path only. Add tests that auto-created folders share explicit and unstamped file dates on nested paths, and a test helper to make separate unstamped new Date() calls observable. Signed-off-by: Jon Koops <jonkoops@gmail.com>
jonkoops
changed the title
jonkoops
changed the title
jonkoops
approved these changes
Sep 9, 2026
jonkoops
left a comment
jonkoops
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @bluelovers for the original fix. I narrowed the change to the bugfix only (pass o.date through folderAdd when file() auto-creates parents) and dropped the public folder() options API, since that would be a new feature rather than part of this fix. Added regression tests for explicit and unstamped dates on nested paths. Updated the linked issue to #590, which is what this actually fixes.
We will leave #609 open for a more comprehensive fix. The folder() options work is a good API addition and we can land that separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #590