Repository navigation
Number the markets package.json step 3 - #4292
Merged
Merged
Conversation
The markets recipe gives the package.json patch the step number "8". The generator set this number from the position of package.json in the list of changed files. The recipe has only steps 1 and 2, so the README, the LLM prompt and the shopify.dev page go from Step 2 to Step 8. The generator keeps the step number that the recipe already has, so a regenerate keeps step "3".
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
lucyxiang
marked this pull request as ready for review
November 2, 2026 21:13
andguy95
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: The markets recipe goes from Step 2 to Step 8. This PR changes the
package.jsonstep to Step 3.Why
The recipe gives the
package.jsonpatchstep: "8". The generator set this number from the position ofpackage.jsonin the list of changed files (String(i)incookbook/src/lib/generate.ts). The recipe has only steps 1 and 2, so the README, the LLM prompt and the shopify.dev page skip from Step 2 to Step 8.What this changes
step: "3"for thepackage.jsonstep incookbook/recipes/markets/recipe.yaml.The generator reuses the step number that the recipe already has (
existingStep?.step), sogenerateandregeneratekeep step"3".Developer impact
No changeset. The cookbook does not ship in a package.