Repository navigation
MP4: Fix handling of extended atoms - #755
Merged
Merged
Conversation
Serial-ATA
force-pushed
the
mp4-fix
branch
2 times, most recently
from
October 24, 2026 03:59
4a07b05 to
7763463
Compare
The parser wasn't fully equipped to handle extended atoms, which is a good thing since they weren't being *written* correctly, either. There's now a test covering both cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parser wasn't fully equipped to handle extended atoms, which is a good thing since they weren't being written correctly, either.
There's now a test covering both cases
closes #746
closes #754