Repository navigation
Fixes for OpenBSD port - #1825
Merged
Merged
Conversation
ligurio
force-pushed
the
ligurio/gh-xxxx-openbsd-port
branch
from
October 14, 2026 12:56
9ef7b3a to
a5423fa
Compare
TheJJ
approved these changes
Oct 14, 2026
TheJJ
left a comment
TheJJ
left a comment
Member
There was a problem hiding this comment.
thanks for the fixes! i'll wait to merge if you want to fixup the commit adding you to mailmap, which is unneeded.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
ligurio
force-pushed
the
ligurio/gh-xxxx-openbsd-port
branch
from
October 15, 2026 06:17
a5423fa to
dd35673
Compare
On OpenBSD include <util.h> (for forkpty()/openpty(), provided by the already-linked libutil), <termios.h>, <sys/types.h> and <sys/ioctl.h> instead of the missing <pty.h>. Implement self_exec_filename() on OpenBSD via sysctl(KERN_PROC_ARGS) argv[0]. OpenBSD has neither /proc/self/exe nor KERN_PROC_PATHNAME, so the previous code hit a static_assert; include <sys/sysctl.h> for it. Define `typedef sig_t` as `sighandler_t` on OpenBSD, which has no sighandler_t.
Do not link libopenage with '-Wl,--no-undefined' on OpenBSD. Shared libraries on OpenBSD are not linked against libc, so the strict undefined-symbol check fails on libc symbols; the flag setup is reworked so the Apple and other-ELF cases are unchanged.
ligurio
force-pushed
the
ligurio/gh-xxxx-openbsd-port
branch
from
October 15, 2026 06:19
dd35673 to
6bad51e
Compare
TheJJ
approved these changes
Oct 15, 2026
ligurio
added a commit
to ligurio/openbsd-wip
that referenced
this pull request
Oct 23, 2026
Upstream has no release newer than 0.6.0, but the OpenBSD fixes were merged to master (PR #1825, merge 8c7d6306), so track that snapshot. Current master requires C++26 modules and clang >= 21, which OpenBSD 7.9 does not ship, so stay at the last C++20 commit. All porting patches are in upstream now and were removed: - 'codegen' -> 'cppgen' target rename; - no '-Wl,--no-undefined' for shared libraries on OpenBSD; - define sig_t as sighandler_t on OpenBSD; - <util.h>/<termios.h> includes in util/pty.h; - self_exec_filename() via sysctl(KERN_PROC_ARGS); - pathfinder no longer initialises entry_sector with NULL. Upstream still calls find_library(RT_LIB rt) unconditionally on non-Apple/non-Windows systems, and OpenBSD has no librt; pass -DRT_LIB= so that CMake does not leave RT_LIB set to RT_LIB-NOTFOUND. Dependencies follow upstream 8c7d6306: Python >= 3.12 and Cython >= 3.1, tomli_w replaces toml, jinja2 is no longer used, and lz4/mako are now runtime dependencies. The packing list picks up the renamed openage/util/toml.py and the new demo_7 shaders. CI installs py3-tomli_w instead of py3-toml and py3-jinja2. Follows up SFTtech/openage#1825
ligurio
added a commit
to ligurio/openbsd-wip
that referenced
this pull request
Oct 23, 2026
Upstream has no release newer than 0.6.0, but the OpenBSD fixes were merged to master (PR #1825, merge 8c7d6306), so track that snapshot. Current master requires C++26 modules and clang >= 21, which OpenBSD 7.9 does not ship, so stay at the last C++20 commit. All porting patches are in upstream now and were removed: - 'codegen' -> 'cppgen' target rename; - no '-Wl,--no-undefined' for shared libraries on OpenBSD; - define sig_t as sighandler_t on OpenBSD; - <util.h>/<termios.h> includes in util/pty.h; - self_exec_filename() via sysctl(KERN_PROC_ARGS); - pathfinder no longer initialises entry_sector with NULL. Upstream still calls find_library(RT_LIB rt) unconditionally on non-Apple/non-Windows systems, and OpenBSD has no librt; pass -DRT_LIB= so that CMake does not leave RT_LIB set to RT_LIB-NOTFOUND. Dependencies follow upstream 8c7d6306: Python >= 3.12 and Cython >= 3.1, tomli_w replaces toml, jinja2 is no longer used, and lz4/mako are now runtime dependencies. The packing list picks up the renamed openage/util/toml.py and the new demo_7 shaders. CI installs py3-tomli_w instead of py3-toml and py3-jinja2. Follows up SFTtech/openage#1825
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openage with its dependencies (nyan and toml11) was ported to OpenBSD 1
Footnotes
https://github.com/ligurio/openbsd-wip/pull/5 ↩