Repository navigation
add c++ module support (and c++26) - #1823
Merged
Merged
Conversation
TheJJ
added
nice new thing ☺
- ubuntu: install ccache in the devenv image, mount a cached ccache dir into the build container, and launch compilers through ccache - macos: replace never-hitting timestamp cache keys with content keys (ccache per commit, deps per workflow file) and drop --force from brew installs so cached installs are not relinked every run
deduplicate 'find files in these locations, filter by check_files'. also convert to using Path
matching location has to be Path-converted
ruff and ty accept directories and direct files, and filter directories themselves via the pyproject.toml config, so the explicit check_files filtering is redundant for them. Side effect: --only-changed-files no longer restricts ruff/ty to changed files; they always check all python locations, which costs well under a second.
C++ module sources (FILE_SET CXX_MODULES) can only be built by generators with dependency scanning; the Makefile generator rejects them. Ninja is now the default, --makefile-generator opts out for module-free builds.
add_sources(... MODULE ...) adds files to the target's CXX_MODULES file set instead of the regular sources, so the ninja generator scans and orders them for module compilation.
cmake 3.28 is the first release with C++ module support (FILE_SET CXX_MODULES); C++26 matches the compiler floor the modules work is targeting.
RULE_LAUNCH_COMPILE is deprecated and its wrapper interferes with the ninja module dependency scanning; the launcher property is the supported mechanism and matches what CI already passes.
color.h disappears; color.cpp exports the module openage.util.color and console.h imports it. The source is registered via the new MODULE modifier of add_sources, which routes it into the CXX_MODULES file set.
Build commands are just recipes now; the minimum compilers are gcc 16 and clang 21.
The configure hint and the kevin CI jobs call just recipes, and CheckCompilerFeatures.cmake states the new minimum compiler versions. The nix derivation and the ubuntu 26.04 devenv image provide just and ninja.
The distro package lists gain just and ninja, bare 'just' lists the recipes and 'just build' builds. macOS builds with Homebrew's LLVM for C++26 module support. gentoo.md moves from layman to eselect repository.
The progress counter shows [0/31] to [30/31] for 31 tests because the 0-based enumerate index is passed to format_progress unchanged. Pass idx + 1 instead.
SFTbot
removed
the
kevin-rebuild-pl0x
TheJJ
force-pushed
the
bump-cpp
branch
5 times, most recently
from
October 20, 2026 13:29
165e3bd to
a22babb
Compare
try_compile with SOURCES_TYPE CXX_MODULE builds a module unit and an importing consumer, so a lacking compiler or generator fails configure with a clear message instead of a cryptic build error later.
Replace the nyan includes with `import nyan;` after the include blocks. Files that relied on nyan's transitive std includes now include what they use.
Replace mom.h/mom.cpp with cat.h/cat.cpp: the same guidelines, re-themed with cats and Aperture Science, and now documenting that module imports come after all includes.
GCC fails with redefinitions when a standard header is included after importing a module whose interface uses the same declarations. GCC builds now compile <bits/stdc++.h> into a header unit, and GCC translates every standard #include into an import of it, so the order no longer matters and headers may import modules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1787