Skip to content

General Clean-up - #1411

Open
Marco-Farruggio wants to merge 17 commits into
RustAudio:masterfrom
Marco-Farruggio:general-cleanup
Open

Marco-Farruggio wants to merge 17 commits into
RustAudio:masterfrom
Marco-Farruggio:general-cleanup

Conversation

@Marco-Farruggio

@Marco-Farruggio Marco-Farruggio commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

As I code a keep a notepad window open and jot down anything I want to think about later, these were a few small tweaks which I've decided to squash into one PR

  • Rename DeviceNotAvailable -> DeviceUnavailable:
    • Why?: Better English, less words, shorter, matches HostUnavailable
  • Normalize thread names:
    • server clients: cpal_<host>_client_<pid>
    • worker threads: cpal_<host>_<dir>
  • Remove unused frames_to_duration on Windows
  • Clean up From<ndk::audio::AudioError> for Error
  • Clean up From<jack::Error> for Error
  • Remove some extern crates
    • Why?: Legacy syntax, I've left some though for now, where it's not a super simple change (e.g., re-exporting)
  • Move some duplicated duplex stream config validation into a new crate::duplex::validate_duplex_config
    • A New OSS Host for FreeBSD #1404 will also use this
    • Some hosts have host-specific requirements which make it more logical to write their own duplex config validation checks, instead of using duplex::validate_duplex_config then checking their own reqs.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant