Skip to content

Optional Stitching - #91

Merged
amobular merged 8 commits into
mainfrom
feature/optional-stitching
Mar 16, 2026
Merged

amobular merged 8 commits into
mainfrom
feature/optional-stitching

Conversation

@amobular

Copy link
Copy Markdown
Collaborator

Changes

  • Added the option to choose whether to remove NaNs in the input data.
  • Changed naming of removing NaNs to "stitching".
  • Added more logging for the stitching/NaN removal process.

Impact

  • No changes in behaviour, default is to not stitch.

@amobular
amobular requested a review from miguelpher March 10, 2026 11:40
Comment thread sam/models/base_model.py Resolved
Comment thread sam/models/base_model.py Resolved
miguelpher
miguelpher previously approved these changes Mar 16, 2026

@miguelpher miguelpher left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good implementation, great testing!

@amobular
amobular merged commit ddeced5 into main Mar 16, 2026
2 checks passed
@miguelpher
miguelpher deleted the feature/optional-stitching branch July 7, 2026 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants