Repository navigation
move SDenv helpers from [ - #7942
Open
ben-schwen wants to merge 2 commits into
Open
ben-schwen wants to merge 2 commits into
ben-schwen wants to merge 2 commits into
Conversation
ben-schwen
force-pushed
the
brk/a7_SDenv
branch
from
October 24, 2026 10:13
5f0c0a1 to
8e5adec
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## brk/a6_check_args #7942 +/- ##
=====================================================
- Coverage 99.09% 99.09% -0.01%
=====================================================
Files 88 88
Lines 17437 17429 -8
=====================================================
- Hits 17279 17271 -8
Misses 158 158 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ben-schwen
force-pushed
the
brk/a7_SDenv
branch
from
October 24, 2026 23:13
8e5adec to
6252710
Compare
(Plot image upload to picrd.com failed; download the artifact below to view plots) Generated via commit 06cf638 Download link for the artifact containing the test results: ↓ atime-results.zip
|
ben-schwen
force-pushed
the
brk/a7_SDenv
branch
from
October 26, 2026 15:13
6252710 to
dcea6e7
Compare
| .dt_new_SDenv = function(jsub, names_x, callenv) { | ||
| SDenv = new.env(parent=callenv) | ||
|
|
||
| syms = all.vars(jsub) |
Member
There was a problem hiding this comment.
jsub is only referenced once, so maybe the argument should be syms (or jvars=all.vars(jsub)) instead?
|
|
||
| syms = all.vars(jsub) | ||
| syms = syms[startsWith(syms, "..")] | ||
| syms = grepv("^[.][.](?:[.]|[0-9]+)$", syms, invert=TRUE) # exclude ellipsis and '..n' ellipsis elements |
Member
There was a problem hiding this comment.
I am still thinking we can combine these two statements e.g.
syms = grepv("^[.][.](?:[^0-9.]|[0-9].*[^0-9])", syms)
Member
Author
There was a problem hiding this comment.
I adapted it to syms = grepv("^[.][.](?:[^0-9.]|[.].|[0-9].*[^0-9])", syms) to also handle ...x searching for .x
MichaelChirico
approved these changes
Oct 26, 2026
ben-schwen
force-pushed
the
brk/a7_SDenv
branch
from
November 1, 2026 21:02
dcea6e7 to
d7c48c7
Compare
ben-schwen
force-pushed
the
brk/a7_SDenv
branch
from
November 1, 2026 22:20
0724500 to
60e765d
Compare
ben-schwen
force-pushed
the
brk/a7_SDenv
branch
2 times, most recently
from
November 3, 2026 09:51
82a3a27 to
fb797db
Compare
ben-schwen
force-pushed
the
brk/a7_SDenv
branch
4 times, most recently
from
November 3, 2026 17:25
cafb38d to
fb98102
Compare
ben-schwen
force-pushed
the
brk/a7_SDenv
branch
from
November 3, 2026 17:46
fb98102 to
dfc5d91
Compare
No behaviour change.
ben-schwen
force-pushed
the
brk/a7_SDenv
branch
from
November 3, 2026 18:02
dfc5d91 to
06cf638
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #852