Repository navigation
Include all tests in the CI coverage run - #57
Merged
Merged
Conversation
Follows-up to #56 The coverage run took its tests from the suites in phpunit.xml.dist, which never listed tests/phpunit/Persistence, so it ran 405 of the 430 tests the other PHPUnit jobs run. It now passes the test directory to PHPUnit, like those jobs, so it runs all 430 and a new test directory cannot be left out again. `-c` still supplies the coverage scope. Only the coverage run used the Integration suite, so this removes it. Plain `vendor/bin/phpunit` in the extension directory now runs the standalone Unit suite, as its comment says, instead of failing on the tests that need MediaWiki. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## mw-1.47-compat #57 +/- ##
====================================================
+ Coverage 83.17% 91.54% +8.36%
Complexity 419 419
====================================================
Files 40 40
Lines 1076 1076
====================================================
+ Hits 895 985 +90
+ Misses 181 91 -90 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows-up to #56
The coverage run took its tests from the suites in phpunit.xml.dist, which never listed tests/phpunit/Persistence, so it
ran 405 of the 430 tests the other PHPUnit jobs run. It now passes the test directory to PHPUnit, like those jobs, so it
runs all 430 and a new test directory cannot be left out again.
-cstill supplies the coverage scope.Only the coverage run used the Integration suite, so this removes it. Plain
vendor/bin/phpunitin the extensiondirectory now runs the standalone Unit suite, as its comment says, instead of failing on the tests that need MediaWiki.