Skip to content

Include all tests in the CI coverage run - #57

Merged
JeroenDeDauw merged 1 commit into
mw-1.47-compatfrom
coverage-all-tests
Oct 27, 2026
Merged

JeroenDeDauw merged 1 commit into
mw-1.47-compatfrom
coverage-all-tests

Conversation

@JeroenDeDauw

@JeroenDeDauw JeroenDeDauw commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

Follows-up to #56

The coverage run took its tests from the suites in phpunit.xml.dist, which never listed tests/phpunit/Persistence, so it
ran 405 of the 430 tests the other PHPUnit jobs run. It now passes the test directory to PHPUnit, like those jobs, so it
runs all 430 and a new test directory cannot be left out again. -c still supplies the coverage scope.

Only the coverage run used the Integration suite, so this removes it. Plain vendor/bin/phpunit in the extension
directory now runs the standalone Unit suite, as its comment says, instead of failing on the tests that need MediaWiki.

AI-authored — Claude Code, Opus 5.5 (max); one-line ask from @JeroenDeDauw, relayed as a detailed brief, no revisions; diff not yet human-reviewed; coverage run checked locally on a MediaWiki 1.43 CI replica and in the CI log (430 tests), CI green.

Follows-up to #56

The coverage run took its tests from the suites in phpunit.xml.dist, which never listed tests/phpunit/Persistence, so it
ran 405 of the 430 tests the other PHPUnit jobs run. It now passes the test directory to PHPUnit, like those jobs, so it
runs all 430 and a new test directory cannot be left out again. `-c` still supplies the coverage scope.

Only the coverage run used the Integration suite, so this removes it. Plain `vendor/bin/phpunit` in the extension
directory now runs the standalone Unit suite, as its comment says, instead of failing on the tests that need MediaWiki.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.54%. Comparing base (b11ae40) to head (8772b1d).

Additional details and impacted files
@@                 Coverage Diff                  @@
##             mw-1.47-compat      #57      +/-   ##
====================================================
+ Coverage             83.17%   91.54%   +8.36%     
  Complexity              419      419              
====================================================
  Files                    40       40              
  Lines                  1076     1076              
====================================================
+ Hits                    895      985      +90     
+ Misses                  181       91      -90     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JeroenDeDauw
JeroenDeDauw marked this pull request as ready for review October 27, 2026 12:26
@JeroenDeDauw
JeroenDeDauw merged commit c4ebef1 into mw-1.47-compat Oct 27, 2026
20 checks passed
@JeroenDeDauw
JeroenDeDauw deleted the coverage-all-tests branch October 27, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants