Repository navigation
[FEATURE] Canvas: edge color scheme and node-size scaling - #1
Draft
SoWieMarkus wants to merge 3 commits into
Draft
SoWieMarkus wants to merge 3 commits into
SoWieMarkus wants to merge 3 commits into
Conversation
Keep this branch focused on automatic graph generation. Remove the edge color scheme (edgeThresholds), node-size scaling (nodeThresholdSizes, sizeMode scaling), and the view-mode zoom interaction change, which move to follow-up PRs stacked on top of this one. Generation plumbing is retained, including the no-op sizeMode:'threshold' on generated nodes and nodeDefaultSize.
Reintroduce the edge color scheme (edgeThresholds, falling back to node thresholds) and value-driven node-size scaling (nodeThresholdSizes, sizeMode) across runtime, editor, schema, and SDK. Also surface edge colors in the legend: when edges use their own color scheme, the panel renders a separate titled "Edges" legend alongside the "Nodes" legend. Signed-off-by: Markus Wieland <markus.wieland@sap.com>
SoWieMarkus
force-pushed
the
feat/canvas-edge-colors
branch
from
October 30, 2026 12:18
bb143de to
fc05624
Compare
Signed-off-by: Markus Wieland <wie.markus@web.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #891, which was kept focused on automatic graph generation. This PR adds the value-driven styling that was split out of that review:
edgeThresholdsoption so edges can be colored independently of nodes. When unset, edges fall back to the nodethresholds, so existing dashboards keep their current edge colors.nodeThresholdSizes+ per-nodesizeMode: "threshold"scale a node's base size by its bound value (relative tonodeDefaultSize). Generated nodes opt into this automatically.Screenshots
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes