Repository navigation
Conversation
29974cc was accidentally pushed to blead without review. It has several issues that should have been fixed before being merged. * Saving old_target makes sense, saving old_key does not; its decrement is already after the targs increment. * For readability its desirable if the decrement of old_target happens directly after the increment of the new target, because that way all the target handling code is together. * In Perl_vivify_defelem there's a repeat of this dance that doesn't seem to serve any purpose (the increment is already before the decrement), it appears to be just a hallucination. * Setting value = NULL is unnecessary because value is already initialized to NULL, so that whole branch could be simplified. * The tests for this do not belong in t/op/for.t, I moved them to t/op/avhv.t instead. * Most of the comments don't make sense because they appear to be about the change and not about the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
29974cc was accidentally pushed to blead without review. It has several issues that should have been fixed before being merged.
Perl_vivify_defelemthere's a repeat of this dance that doesn't seem to serve any purpose (the increment is already before the decrement), it appears to be just a hallucination.value = NULLis unnecessary because value is already initialized toNULL, so that whole branch could be simplified.