Skip to content

[RF] Fix handling of min_samples_leaf and min_samples_split parameters - #8816

Draft
chyunsu3 wants to merge 5 commits into
NVIDIA:mainfrom
chyunsu3:fix_min_samples_leaf
Draft

chyunsu3 wants to merge 5 commits into
NVIDIA:mainfrom
chyunsu3:fix_min_samples_leaf

Conversation

@chyunsu3

@chyunsu3 chyunsu3 commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor
  • Bootstrap draws are compressed into distinct row IDs plus multiplicity counts.
  • Impurity calculation and leaf predictions now use bootstrap multiplicities, keeping the equivalent results with the status quo.
  • The min_samples_leaf and min_samples_split constraints are now enforced by counting the number of distinct training rows.
  • This brings cuML RF in line with scikit-learn RF.

Closes #8813

@copy-pr-bot

copy-pr-bot Bot commented Oct 24, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions Bot added Cython / Python Cython or Python issue CUDA/C++ labels Oct 24, 2026
@chyunsu3 chyunsu3 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 24, 2026
@chyunsu3
chyunsu3 force-pushed the fix_min_samples_leaf branch from 44be560 to 4e4ff0c Compare October 24, 2026 05:08
@chyunsu3

Copy link
Copy Markdown
Contributor Author

/ok to test dafa977

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] In RF, min_samples_leaf not enforced when bootstrap=True

2 participants