Repository navigation
Remove checksum from skin upload metadata - #106
Merged
Merged
Conversation
Texture upload URLs act as their own hash, so checksum has never been needed. If skin history doesn't come back sorted, open an issue on the skin server. # Conflicts: # src/main/java/com/minelittlepony/hdskins/server/ValhallaSkinServer.java
mattmess1221
force-pushed
the
feat/remove-checksum
branch
from
November 4, 2026 01:29
0224393 to
be01a0d
Compare
Member
|
Checksums are there to filter duplicates (as the skin server previously would display multiples of the same skin when getting the history). If you can confirm that's not the case now we can remove it. |
Member
Author
|
Yes, they've been deduplicated since MineLittlePony/ValhallaSkinServer@87fb636. |
Sollace
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Texture upload URLs act as their own hash, so checksum has never been needed.
If skin history doesn't come back sorted, open an issue on the skin server.