Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Removing the header-height measurements leaves headerViewHeight at zero in Home and Sidebar, delaying the navigation-title fade by the header height.
1 open issue
What changed in this PR
This PR removes early header-height reads from the Home and Sidebar screens to avoid measuring supplementary views before layout.
Changes:
- Removes
headerViewHeightassignments during header creation in both controllers.
| File | Description |
|---|---|
kDrive/UI/Controller/Home/HomeViewController.swift |
Removes the Home header’s pre-layout height read. |
kDrive/UI/Controller/Files/SidebarViewController.swift |
Removes the Sidebar header’s pre-layout height read. |
Review effort: Balanced
BaptGrv
force-pushed
the
fix/sidebar-header
branch
from
November 9, 2026 08:13
2cddcc3 to
3657036
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.