[BaptGrv]

No description provided.

[Copilot]

🟡 Changes recommended

Compilation is blocked by an implicit-self access in an escaping closure and a nonconforming test delegate, with additional playback and control-state defects unresolved.

7 open issues

• Add isFullscreenPreview to the PDFPageDelegate test double · New
• Qualify the controlsView reference with self · New
• Allow pausing while playback is buffering · New
• Rewind completed videos before replaying · New
• Remove the playback observer before clearing the player · New
• Hide controls when resetting a reused cell · New
• Commit VoiceOver slider adjustments immediately · New

What changed in this PR

This PR replaces native video preview controls with custom UIKit controls, integrating playback controls into kDrive’s preview layout and sharing visual styling with audio previews.

Changes:

• Adds layer-based video rendering, custom playback and seeking controls, AirPlay, and picture-in-picture setup.
• Connects control visibility to fullscreen preview state.
• Shares media control styling and remaining-time formatting between audio and video.

File	Description
kDriveCore/​VideoPlayer/​VideoPlayer.swift	Exposes the underlying player for custom rendering.
kDriveCore/​AudioPlayer/​SingleTrackPlayer.swift	Extracts remaining-time formatting with duration handling.
kDrive/​UI/​View/​Files/​Preview/​VideoControlsView.swift	Adds custom playback, seeking, time, and AirPlay controls.
kDrive/​UI/​View/​Files/​Preview/​VideoCollectionViewCell.swift	Integrates custom rendering, controls, and playback observation.
kDrive/​UI/​View/​Files/​Preview/​TouchTrackingGestureRecognizer.swift	Removes the native-control touch tracker.
kDrive/​UI/​View/​Files/​Preview/​PreviewCollectionViewCell.swift	Adds a fullscreen-change callback.
kDrive/​UI/​View/​Files/​Preview/​PlayerLayerView.swift	Adds a UIView backed by AVPlayerLayer.
kDrive/​UI/​View/​Files/​Preview/​MediaPlaybackStyle.swift	Centralizes time-label fonts and slider-thumb rendering.
kDrive/​UI/​View/​Files/​Preview/​AudioCollectionViewCell.swift	Adopts shared media styling.
kDrive/​UI/​Controller/​Files/​Preview/​PreviewViewController.swift	Exposes fullscreen state and notifies visible preview cells.

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

Unresolved issues cause incorrect remaining-time labels at playback completion, stale playback controls after reversed swipes, and VoiceOver slider adjustments that fail to seek while paused.

1 open issue

• Clamp remaining time to zero at the media endpoint · New

1 previously missed issue

In code that hasn't changed since last review

Update pause controls after the video leaves the current page

kDrive/​UI/​View/​Files/​Preview/​VideoCollectionViewCell.swift:255

didEndDisplaying clears isCurrentPage before pausing, so this guard drops the pause-state update. If the user reverses a swipe and returns to the video before its cell leaves the collection view, the controls can retain the pause icon even though startFromBeginning leaves playback paused. Update the controls for the attached player even when its cell is not the current page.

7 resolved since last review

• Qualify the controlsView reference with self
• Add isFullscreenPreview to the PDFPageDelegate test double
• Commit VoiceOver slider adjustments immediately
• Hide controls when resetting a reused cell
• Remove the playback observer before clearing the player
• Rewind completed videos before replaying
• Allow pausing while playback is buffering

_{Review effort: Balanced}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud