Skip to content

More bot-enabled shops, activities, and navigation; fix equipment resolution and floor item pickup - #1398

Draft
trunksbomb wants to merge 42 commits into
GregHib:mainfrom
trunksbomb:bot/more-shops-and-activities
Draft

trunksbomb wants to merge 42 commits into
GregHib:mainfrom
trunksbomb:bot/more-shops-and-activities

Conversation

@trunksbomb

@trunksbomb trunksbomb commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

This is a follow up PR to #1385.

Connect more shops to NPCs and areas so bots can use them

  • Add more tagged skilling areas and nav endpoints in existing areas.
  • Expand navigation around Lumbridge, Varrock, Al Kharid, Rimmington, Dwarven Mines, Living Rock Caverns, Edgeville Dungeon, Daemonheim, Rogue's Den, and Heroes' Guild.
  • Fix Al Kharid gate edges: Pay-toll for bots in the existing navigation did not work due to invalid syntax.
  • Add bronze through steel platebody smithing activities at West Varrock anvils.
  • Add Hill Giants Attack/Strength/Defence activities with equipment setup, banking, and a brass key pickup resolver.
  • Define missing objects and update their teleport references.

Kotlin changes

  • Fix off-by-one in floor item pickup. The action sent index + 1, but the handler expects index, causing pickup to fail. Observed when testing the brass key pickup resolver for Hill Giants.
  • Exclude satisfied equipment slots when resolving setup. Multiple unmet slots could cause a loop withdrawing/equipping items that were already satisfied. Observed when gearing up for Hill Giants when the bot is missing one or more pieces of equipment. Fixes Bot inventory setup gets stuck in a deposit/withdraw loop when a required item is missing #1394.
  • Add forced walk-through behavior for Heroes' Guild doors. Doesn't check for requirements yet.
  • Heroes' Guild ladder up from the basement didn't work because Creature of Fenkenstrain had a handler for that object taking precedence. Fixes Broken ladder in Hero's Guild #1387.

…s. Stopped at Tirannwn because bots can't reliably navigate the traps yet
…wn to the Observatory and Castle Wars, and east to Yanille
…erDoor` for the automatic walk-then-close behavior
…ard. Connect Yanille to Feldip Hills and Gu'Tanoth
…ng putting nav edge endpoints in more areas so bots can reach them; fix an erroneous `amount` declared for coins on the Al Kharid gate which prevented bots from using it.
…and remove `capacity` from three recently introduced smithing activities
…equires 10gp and has a higher routing cost, and an Open option that requires Prince Ali Rescue completion and has a cheaper route cost.
…d connect southern Wilderness mining and obelisks

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bot inventory setup gets stuck in a deposit/withdraw loop when a required item is missing Broken ladder in Hero's Guild

1 participant