Repository navigation
fix: show mirrored approvals once the Session is visible - #27
Merged
Merged
Conversation
Keep a mirrored approval queued until the mirror runtime exists and a client reports the Session visible, then hand it to the ordinary approval UI. This preserves native waiting semantics instead of answering unavailable when no local prompt is available. Deduplicate replayed approval ids so two clients see one pending event. Add fake-host approval support and a two-client Playwright test that verifies one answer dismisses the other client and the remote agent receives exactly one answer. Refs #22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22.
Original problem
An approval for a mirrored remote Session could be answered automatically with
unavailablewhen the local mirror runtime was not ready: the approval stream starts before the first session sync, so the user never saw the prompt and the remote turn could appear stuck. The approval was also dispatched as soon as the runtime mounted, before a client could present it.Change
Fixed during this change
Resolved
unavailableon the user's behalf.Unresolved
Testing
pnpm --filter dsh-remote-local-plugin test(129/129)pnpm --filter dsh-remote-local-plugin typecheckpnpm --filter @dsh-remote/testkit typecheckallowed-once.