Repository navigation
fix: restore gateway terminal endpoints for the terminal fork - #26
Merged
Merged
Conversation
The stock terminal-controller row is disabled, so the fork must export ./typert; without it the loader withdrew every terminal endpoint. Re-own the stock manifest under the fork package and route gateway calls for mirrored Sessions through RemoteTerminals while local Sessions keep the stock controller. Add manifest, routing, and packaging coverage. Refs #23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23.
Original problem
With the plugin installed, gateway terminal clients failed on
terminal/shellswithits strict definition was withdrawn and SRC fallback is forbidden. The stock terminal-controller row is disabled and the fork package did not export./typert, so the loader withdrew the stock descriptors and the gateway could not resolve any terminal endpoint.Change
./typerthost face todsh-remote-terminal-controllerthat re-owns the stock terminal manifest under the fork package name.RemoteTerminals; local Sessions keep the stock controller, so a gateway terminal for a mirrored Session does not spawn a local shell.Fixed during this change
Resolved
terminal/shells,terminal/list,terminal/create,terminal/attachand the other terminal endpoints resolve again for gateway clients.Unresolved
Testing
pnpm --filter dsh-remote-terminal-controller test(3/3)pnpm --filter dsh-remote-local-plugin test(127/127)pnpm --filter dsh-remote-local-plugin typechecknode_modules/dsh-remote-terminal-controller/lib/typert.host.js, its.d.ts, and the./typertexport.terminal/shellsreached the endpoint and returnedsession/not-foundfor a fake agent instead of 404 /definition-unavailable;terminal/listreturnedokwith an empty list.