Repository navigation
fix: browse remote Linux workspaces from a Windows client - #25
Merged
Merged
Conversation
The workspace-files adapter used the client platform path for both the local anchor and the remote POSIX root, so a Windows client turned /home/ubuntu into C:\home\ubuntu before calling the remote agent. Split the two path namespaces in a pure resolver and cover the Windows and POSIX cases, including the real Windows host run. Refs #21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21.
Original problem
On a Windows client, opening a mirrored remote workspace resolved the remote POSIX path with the client platform path implementation.
/home/ubuntubecameC:\home\ubuntu, was sent asremotePathto the remote agent, and file list/stat/read failed withnot found: C:\home\ubuntu.Change
/separators before joining the remote root.Fixed during this change
Resolved
Unresolved
Testing
pnpm --filter dsh-remote-local-plugin test(126/126)pnpm --filter dsh-remote-local-plugin typecheckpnpm --filter dsh-remote-local-plugin buildnode:path;/home/ubuntustays/home/ubuntu, the local anchor uses backslashes, and all cases pass.