Repository navigation
fix: provision remote hosts without Node or nvm - #24
Merged
Merged
Conversation
The node path prelude ran an unguarded nvm glob under set -euo pipefail, so a missing nvm directory aborted the whole bootstrap before the configured Node auto-install step. Guard the glob with compgen and cover the no-nvm path by executing the prelude in a POSIX shell test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20.
Original problem
On a fresh remote host without Node, the generated bootstrap exited with status 2 before the automatic Node install could run.
nodePathPrelude()ran an unguardedlsover the nvm version glob underset -euo pipefail; with no nvm installation, the glob did not match,lsexited non-zero, andset -eterminated the script.Change
|| true) so a missing nvm directory cannot abort the bootstrap.Fixed during this change
Resolved
Unresolved
Testing
pnpm --filter @dsh-remote/installer test(20/20)pnpm --filter @dsh-remote/installer typecheckpnpm --filter @dsh-remote/installer builddsh webstarted, and the agent state reached ready.