Skip to content

JavaScript extensions improvements - #2282

Open
Odonno wants to merge 2 commits into
CommunityToolkit:mainfrom
Odonno:fix/js-hosting-ext
Open

Odonno wants to merge 2 commits into
CommunityToolkit:mainfrom
Odonno:fix/js-hosting-ext

Conversation

@Odonno

@Odonno Odonno commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Started from an issue there

context.Args.Insert(0, executionAnnotation.ScriptCommand ?? "nx");
and did some more changes:

  • Put each monorepo implementation into a separate file to see more clearly (with a constant CliName to avoid possible mistakes)
  • Fix the issue from the link above
  • Add a new monorepo implementation for Vite+ now the v1 is released, see https://voidzero.dev/posts/announcing-vite-plus-1-0

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • New integration
    • Docs are written
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

Other information

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 2282

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 2282"

@Odonno
Odonno force-pushed the fix/js-hosting-ext branch from d91d033 to b2960ac Compare October 24, 2026 18:45

@aaronpowell aaronpowell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit and once CI is passing should be right to approve and publish.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's drop this

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a Zed user, I feel ostricized, but OK.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

@Odonno
Odonno force-pushed the fix/js-hosting-ext branch from b2960ac to 3794957 Compare October 27, 2026 18:21

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants