Repository navigation
Flip card, small text sizes, surface/tone cleanup, contrast and grain fixes - #7
Merged
Merged
Conversation
The base .csa-btn:hover sets color: white, and .csa-btn-tertiary:hover only set the background, so tertiary text turned white over its light orange wash. Restate the o500 text color in the tertiary hover rule. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A CSS-only card with a front and a back that turns over on click, from the Working Groups prototype. A visually hidden checkbox holds the flipped state and a label covering each face makes the whole card the click target; links on the back stay clickable, keyboard users flip with Space. Hover tilts the card toward the turn; reduced motion cross-fades instead. .csa-sr-only (utility.css) hides the checkbox and screen-reader-only link text. Showcase row after the hover cards, and README entries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The standalone Color helpers section becomes a "Color Helpers" tab next to Extended Palette, and its top-nav link is removed. The section heading had also missed the csa-title class. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ards color-helpers.css now defines .csa-bg-n25 as an !important background utility, so the class meant two things. data-tone="neutral" is now the only neutral-tone hook: the alias rules in surfaces.css, tags.css and toggles.css are removed and the showcase demos use the tone. A light surface's cards are themselves n25, so neutral tags and toggle tracks inside them vanished. They now step up one shade automatically inside .csa-card/.csa-card-media on a light surface (not on gradient or neutral-tone surfaces, whose cards are white). The context is wrapped in :where() so nested dark/black sections still win. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Adds two size values and matching classes, giving a 12 / 14.5 / 16 / 18 scale: - --text-small (14.5px) + .csa-block-small, for short paragraphs - --text-caption (12px) + .csa-caption, for dates, bylines, footnotes, captions and form hints Components move onto the values: buttons, .csa-go, tabs, nav links and checkbox labels use --text-small; form hints/errors, the quote title and "Clear all" use --text-caption; carousel card copy moves to --text-small. Small-text grays move off --n300, which fails AA at these sizes, to --n400. The remaining half sizes are rounded (kicker-sub 12, accordion header 18, accordion text / quote name / hero mission 16). Showcase Typography rows and a README section document the scale. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Form error text on dark/black: r100 (r400 was 2.4:1, r200 4.3:1). Form hint on black: n200 (n300 was 4.3:1). - Dark glass and reveal card links: white, n75 on hover (b300 read poorly on the glass's navy cast). The glass link rules now also outrank the dark/black surface .csa-go rules, which used to win when a glass card sat inside a dark section. - Dark glass and reveal card kickers: o200 (o500 dropped to ~4:1 over lighter photo areas); .csa-kicker-blue on dark glass: b100. Hero kickers are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The grain is a 200px SVG noise tile with stitchTiles, but its filter set only x/y, so the filter region defaulted to 120%: the noise was stitched on a 240px tile and cut at 200px, leaving a faint seam at every tile edge (seen as a vertical line ~199px into reveal cards). Setting the filter's width/height to 100% makes it stitch exactly at the tile edges. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Brings in Alain's o200 icon-page variant (identical to the change this branch had, which was dropped), .csa-card-disabled, and data-surface on .csa-card itself. surfaces.css conflict: kept the card-level [data-surface].csa-card selectors and dropped the two .csa-bg-n25 ones, since this branch retires that alias. The automatic light-card tag/toggle step-up now also covers a card that carries data-surface="light" itself (and skips one that carries gradient or the neutral tone). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cloud-b500.svg lives in icons/b500/, so the demo image 404ed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Brings in .csa-list and the reveal panel link change. buttons.css conflict: both sides had the same tertiary hover fix; kept this branch's version, which has the explanatory comment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Removes the stretched .csa-go::after from 8bbb19e: the preferred behavior is for the glass panel not to act as a link, only the link itself. Keeps that commit's cursor fix (.csa-card-reveal:has(.csa-go) { cursor: auto }), so the pointer shows only over the link instead of across the whole card. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Invisible padding (10px above/below, 14px either side) cancelled by negative margins, so the link text does not move but its hit area grows from ~23px to ~44px tall. The scrolling -more-inner reaches 14px further left, and 10px further down while open (:hover only, so the row still collapses to 0 at rest), so it does not clip the extension. Only the link is clickable; the panel itself still is not. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This reverts commit 7498ecf.
This reverts commit 6fa0e3d.
Collaborator
Author
|
Merging this myself for the sake of getting some important updates made ahead of the STAR pages shipping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A week of library updates, one commit per topic:
Tertiary button hover: the base
.csa-btn:hover { color: white }was turning tertiary text white over its light orange wash. The text now stays--o500..csa-card-flip(new): a CSS-only card with a front and a back that turns over on click, from the Working Groups prototype..csa-sr-onlyutility (visually hidden, still read by screen readers).Color helpers: moved into a "Color Helpers" tab in the Color palette section, and the section heading now has
csa-title..csa-bg-n25is now only a color helper:color-helpers.cssmade it an!importantbackground utility, so the class meant two things.data-tone="neutral"is now the only neutral-tone hook, and the alias rules insurfaces.css,tags.cssandtoggles.cssare removed.Automatic tag and toggle step-up in light cards: a light surface's cards are themselves n25, so neutral tags and toggle tracks inside them blended in. They now step up one shade automatically.
data-surface="light"section or carries the attribute itself.Small text sizes: two new values and classes, giving a 12 / 14.5 / 16 / 18 scale:
--text-small(14.5px) with.csa-block-small, for short paragraphs--text-caption(12px) with.csa-caption, for dates, bylines, footnotes, captions and form hintsComponents move onto these values. The library's other half sizes are rounded to whole pixels. Small-text grays move from
--n300, which fails WCAG AA at these sizes, to--n400.Contrast on dark glass and dark surfaces:
--r100--n75on hover--o200.csa-kicker-blueon dark glass:--b100Glass grain seam: see the note below.
Merged
main, bringing in Alain's three Oct 12 commits:.csa-card-disabled: merged as-is. I also fixed its demo's broken icon path.data-surfaceon.csa-carditself: merged with one change. The two.csa-bg-n25card-level selectors were dropped, because this branch retires that alias.Merged
mainagain for Alain's two Oct 15 commits:.csa-list: merged as-is. It also carried the same tertiary hover fix as this branch, which caused thebuttons.cssconflict. I kept this branch's version, which has the explanatory comment.8bbb19e): merged as-is.@apannetrat: input wanted on the small text sizes
Alain, we're trying to consolidate and better define the library's smaller text sizes. Small text was set inline at 13, 13.5, 14 and 14.5px across the showcase and prototypes. This PR names two steps,
--text-small(14.5px) and--text-caption(12px), and moves components onto them. Could you weigh in on whether this is a good idea, or whether you'd approach it differently? Happy to adjust before this merges.Notes for the website
x/y, so the filter region defaulted to 120%. The noise was stitched on a 240px tile and cut off at 200px, which left a faint seam at every tile edge. It shows on the STAR resources review page (pr-3114) as a vertical line about 199px into the reveal cards, in Chrome, at rest and on hover. Setting the filter'swidth/heightto100%fixes it. I confirmed it on that page by overriding the grain: line present, then gone, texture intact. The site will keep showing the line until it picks up this version of the library.data-surface="light"andcsa-bg-n25on the card itself. With this PR it stays n25 and its CCM / CAIQ / "Level 1 & Level 2" tags step up automatically, matching today's look.csa-bg-n25on it is now redundant and can be removed whenever convenient. Don't swap indata-tone="neutral"on that card: with card-level surfaces, that turns it white.Known issue (not fixed here)
Inside a
data-tone="neutral"section, tags and toggles still step up one shade even inside that section's white cards. The tone's rules match any ancestor, not just the nearest background. They're still visible, just one shade darker than needed. A follow-up could have each background set the tag colors through custom properties, so the nearest background always wins.Test plan
Checked in the browser (computed styles plus visual checks) on the showcase:
--o500text on light and dark.csa-title.data-surfacethemselves and dark/black nested in light. Pressed tags keep their color while hovered.<p>and inside cards.--n75on hover.node build.mjswasn't run (no Node on the machine this was built on).🤖 Generated with Claude Code