Skip to content

Homepage: keep 1600px gallery images and test draw-down #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ngnijland merged 2 commits into from
Oct 14, 2026
Merged

Homepage: keep 1600px gallery images and test draw-down #1227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2cfa51
Homepage: keep 1600px gallery images and test draw-down
ngnijland Oct 14, 2026
4d6f694
Merge branch 'master' into claude/homepage-scroll-review-followups
ngnijland Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions docs/src/components/home/Media.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,10 @@ interface Props {
// Videos stay on their poster until the presentation's script loads and
// plays them (src/lib/utils/autoplay.ts, CloserLook.astro).
// `sizes` is the width the media can take inside its frame, inset and all,
// not the frame's: the widest variant then fits a Retina screen at the
// widest layout, and nothing larger is decoded as the page scrolls.
// not the frame's, so a 2x screen picks the variant that fits the media
// rather than its frame. 1600 covers the widest gallery media (808px) and
// 1440 the stage media (720px); nothing larger is decoded as the page
// scrolls.
const { media, sizes, class: className } = Astro.props;
---

Expand All @@ -22,7 +24,7 @@ const { media, sizes, class: className } = Astro.props;
<Image
src={media.src}
alt={media.alt}
widths={[360, 640, 800, 1200, 1440]}
widths={[360, 640, 800, 1200, 1440, 1600]}
sizes={sizes}
class={className}
/>
Expand Down
2 changes: 1 addition & 1 deletion docs/tests/build-output.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ test("homepage scroll-linked effects stay off the main thread", () => {
assert.deepEqual(keyframes("reveal"), ["translate"]);
assert.deepEqual(keyframes("light-up"), ["translate"]);
assert.deepEqual(keyframes("light-up-text"), ["translate"]);
for (const name of ["settle", "recede", "draw", "slide-in"]) {
for (const name of ["settle", "recede", "draw", "draw-down", "slide-in"]) {
for (const property of keyframes(name)) {
assert.match(
property,
Expand Down
Loading