Repository navigation
Notifications: Keep the panel open after trashing or spamming a comment - #116046
Draft
StevenDufresne wants to merge 4 commits into
Draft
StevenDufresne wants to merge 4 commits into
StevenDufresne wants to merge 4 commits into
Conversation
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. |
The busy Trash/Spam button (and the simplified Actions toggle) was natively disabled while the request ran, which dropped focus to the body and tripped the host popover's focus-outside close. Keep those controls focusable while busy, and when the closed note was hidden, move focus to the nearest visible note's row instead.
DataViews' infinite scroll keeps every row it has been given and never drops one that leaves `data`, so a trashed note stayed visible once the panel no longer closed. Pass every visible note as a single page starting at the first note, with `perPage` tied to the note count, so any removal makes DataViews rebuild its rows. Scroll requests now raise a target note count that the fill effect loads towards.
StevenDufresne
force-pushed
the
fix/notifications-trash-keeps-panel-open
branch
from
November 6, 2026 05:19
7f3c393 to
18fdaac
Compare
Sending a reply closed the whole panel. Clicking Send left focus on the button, which then disabled itself once the field cleared, and Cmd+Enter blurred the field. Either way focus fell to the body, which the host popover treats as a click outside. Keep the Send button focusable while disabled and move focus to it after a successful send. DOTCOM-19088
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Why are these changes being made?
Testing Instructions
Pre-merge Checklist