Skip to content

Comments: Let a host sign in embed previews, and find Embed by provider name - #54664

Merged
arcangelini merged 2 commits into
trunkfrom
update/comments-embed-keywords
Nov 7, 2026
Merged

arcangelini merged 2 commits into
trunkfrom
update/comments-embed-keywords

Conversation

@arcangelini

@arcangelini arcangelini commented Nov 7, 2026 •

Copy link
Copy Markdown
Member

Proposed changes

Embeds don't work in the Reader's comment editor, and the Embed block is hard to find. Two changes:

  • A host can sign in its embed previews. The editor previews an embed by fetching labels.embedUrl without credentials, and turns any 4xx into a link. That suits a site's own public preview route, but the Reader's route answers signed-in readers only, so every lookup got a 401. mountEditor now takes an optional fetchEmbed( url ) returning a Response, and the embed block uses it in place of its own request. Left out, nothing changes. The Reader passes one that goes through its signed-in API client (Comments: Sign in the comment editor's embed previews so embeds work in the Reader wp-calypso#116348).
  • /youtube finds the Embed block. Core's embed block shows up for provider searches through its variations, but this editor registers its own core/embed with no variations or keywords, so only /embed matched. It now has keywords for common providers in core's oEmbed list, plus "video" and "audio".

Related product discussion/links

Does this pull request change what data or activity we track or use?

No.

Testing instructions

Created with Claude Opus 5.5 in Claude Code.

@arcangelini
arcangelini requested a review from a team as a code owner November 7, 2026 12:34
@arcangelini arcangelini self-assigned this Nov 7, 2026
@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the update/comments-embed-keywords branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/comments-embed-keywords
bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/comments-embed-keywords

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions Bot added [Package] Comments [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Nov 7, 2026
@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: December 8, 2026
    • Code freeze: December 7, 2026

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions Bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Nov 7, 2026
@jp-launch-control

jp-launch-control Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@arcangelini arcangelini changed the title Comments: Find the comment editor's Embed block by provider name Comments: Let a host sign in embed previews, and find Embed by provider name Nov 7, 2026
@arcangelini
arcangelini merged commit 82c222e into trunk Nov 7, 2026
92 checks passed
@arcangelini
arcangelini deleted the update/comments-embed-keywords branch November 7, 2026 12:56
@github-actions github-actions Bot removed the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Nov 7, 2026
@github-actions github-actions Bot added this to the jetpack/16.5 milestone Nov 7, 2026
@github-actions github-actions Bot added the [Status] UI Changes Add this to PRs that change the UI so documentation can be updated. label Nov 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Comments [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] UI Changes Add this to PRs that change the UI so documentation can be updated.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant