Repository navigation
Podcast: Warn about site visibility before directory submission - #54663
robertbpugh wants to merge 5 commits into
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 1 file.
|
There was a problem hiding this comment.
🟡 Changes recommended
The visibility checks incorrectly retain a warning on public Atomic sites with stale blog_public = '-1'; both checks need host-aware normalization and regression coverage.
1 open issue
What changed in this PR
This PR adds an advisory site-visibility warning to Podcast Distribution, helping users check visibility before submitting their feed to directories.
Changes:
- Detect visibility settings server-side and expose the result to the dashboard.
- Show a warning linking to Settings → Reading without changing setup-button availability or remaining-step counts.
- Add visibility regression cases and package/plugin changelog entries.
| File | Description |
|---|---|
projects/plugins/jetpack/changelog/fix-pods-213-site-visibility |
Document the warning for Jetpack users. |
projects/packages/podcast/tests/php/Admin_Page_Test.php |
Add visibility-state regression cases. |
projects/packages/podcast/src/dashboard/distribution/index.tsx |
Display the advisory warning and settings link. |
projects/packages/podcast/src/dashboard/declarations.d.ts |
Declare the dashboard visibility flag. |
projects/packages/podcast/src/class-admin-page.php |
Compute and inject site visibility. |
projects/packages/podcast/changelog/fix-pods-213-site-visibility |
Record the Distribution change in the package changelog. |
Review effort: Balanced
| $is_site_public = 1 === (int) get_option( 'blog_public', 1 ) | ||
| && 'unlaunched' !== get_option( 'launch-status' ) | ||
| && ! $status->is_private_site() |

Review: needs an approval before merge.
Podcast Distribution now warns when your site is unlaunched, private, or hidden from search engines, with a link to site visibility settings.
Fixes PODS-213
Proposed changes
Known limitations: Existing metadata and episode checks can still disable manual Set up buttons, including saved URLs. The warning checks visibility flags, not directory access to the feed; custom robots.txt rules and other crawler restrictions are outside its scope. Reload the dashboard after changing visibility.
Risk: Incorrect visibility detection could show or omit the advisory warning.
How to revert: Revert this change.
Related product discussion/links
None.
Does this pull request change what data or activity we track or use?
No new tracking or stored data; the dashboard reads existing visibility settings.
Testing instructions
Tested: No live-site or browser verification.
Added a regression test for site visibility detection in
Admin_Page_Test.php.Acceptance (fresh agent, head 8f0084d)
has_product_accesstrue. Growth license failed to issue.VERDICT: PASS
Opened by the bug pipeline for PODS-213.