[giunatale]

With YouTube playing in Fermata Auto, the media session often didn't reflect what was on screen: cards for videos nobody was watching, cards left behind after leaving a video, and Android Auto's autoplay waiting on Fermata for nothing. Seven commits, each fixing one cause, plus one addressing the review (the inactive session during playback was fixed separately by #849, so it's no longer part of this PR):

• Ignore YouTube feed previews in playback state. The home feed autoplays muted previews in the same player, and they were reported as playback. A muted video outside /watch and /shorts is now treated as a preview; it's reported once it's unmuted on a video page.
• Stop playback when the YouTube page leaves the video. YouTube's own back button navigates within the page, and the video keeps playing muted and hidden as the home preview, so the session kept reporting playback. Leaving a video page now stops playback, the same as Fermata's goBack() already did.
• Take the YouTube video title from the player. The title came from document.title, which YouTube updates some time after opening a video, so the card could say "YouTube". It now comes from the player's getVideoData(), falling back to the page title, and is decoded from the JSON that evaluateJavascript() returns, which had quoted the title and shown its quotation marks escaped.
• Stop YouTube playback when its page is destroyed. Exiting Fermata Auto from Android Auto's launcher destroys the YouTube page, but its engine stayed current: the session kept reporting playback and play requests went nowhere. Playback now stops when the page's activity is destroyed. Switching to another section only detaches the page, which is shown again when coming back, so that doesn't stop anything. Stopping also no longer asks an engine without a current item for its position, which a destroyed page may never answer.
• Report at once when there is nothing to resume. A play request with no current playback and no last played item did nothing, so callers such as Android Auto's autoplay after a YouTube session waited until they timed out. Fermata now reports an error immediately. A stopped external item (e.g. a web video), which the service can't resume, also no longer keeps its title on the card.
• Pause when the car disconnects. Switching the car off doesn't always close Fermata's car screen or send it a pause (Android Auto pauses the app it considers its media source, which may be another one), so the video carried on from the phone. Fermata Auto now listens to the car connection updates that Android Auto broadcasts (the same ones the Car App Library's CarConnection uses) and pauses when the car goes from connected to not connected. This pauses whatever is playing, music included, as other media apps do.
• Reopen the YouTube video on a new car screen. A car screen has no saved state to restore its page from, as a phone screen does. When Android Auto started again after such a disconnect, the new screen opened on YouTube's home while the previous page kept playing out of sight, until it was destroyed and stopped, and play then had nothing to resume. The new car screen now takes over the previous one's video at its position: playing or paused as it was if its page is still there, paused if the page is already gone.

Tested on a OnePlus 12 (Android 16) with Android Auto 17.7, on the phone and in the car. Checked: media card and AA media bar during playback, no card from feed previews, the card going away on every exit path (YouTube's back button, Fermata's back, exiting Fermata Auto from AA's launcher), the right title from the start, and AA's autoplay no longer hanging on Fermata. Session state was checked with logcat -s MediaSessionService. The car disconnect pause and the video takeover are also tested in the car, though not extensively yet. The last commit addresses the review.

[AndreyPavlenko]

Review of the last two commits (car disconnect pause, new car screen takeover), plus notes on the rest.

1. closedVideo never expires. It is static for the life of the process. It is written in onActivityEvent(ACTIVITY_DESTROY) for phone activities too, not only car ones, so a later car screen can reopen a stale phone video. Suggest writing it only when a.isCarActivity() and/or adding a time limit.

2. urlChanged stops any YoutubeMediaEngine, not only this page's. doUpdateVisitedHistory calls cb.onStop() on whichever YouTube engine is current. Add the same eng.getWebView() == this guard that getVideo already uses. Robustness issue rather than a confirmed bug, since takeOverVideo has already stopped the engine in the takeover case.

3. /live/ and /embed/ are not handled. isVideoUrl and the JS regex only cover /watch and /shorts. Leaving a live video for a non-video page would stop playback, and a muted live stream would be treated as a feed preview. The Java and JS rules are also duplicated; a comment linking them would help keep them in sync.

4. Car disconnect pauses every engine, including music. Probably intended, but say so in the PR description.

5. Minor: the CarConnectionState query runs on the main thread in the constructor and in onReceive. It is small, but it is still cross-process IPC.

Verified and not an issue: configChanges in both main activities covers rotation, so ACTIVITY_DESTROY does not fire on rotation. The auto manifest already declares the androidx.car.app.connection provider under <queries>. FermataWebView registers its activity listener correctly.

Not checked: the 3 s delayed seek/pause race in the takeover flow, and the last two commits have not been tested in the car.

Reviewed by Claude

[giunatale]

Thanks! Rebased on master and addressed in 7325379:

1. closedVideo: now written only when a car screen is destroyed. A phone screen restores its own video from its saved state, so it never needed it. No time limit: it lives only as long as the process, and it always reopens paused, so at worst a car screen opens on the last video, ready to play.
2. urlChanged: now stops only this page's engine (eng.getWebView() == this), as getVideo does.
3. /live and /embed: both now count as video pages, in isVideoUrl and in the JS isPreview, and each one has a comment pointing to the other.
4. Car disconnect pauses everything: intended, as other media apps do. It's in the PR description now.
5. Main-thread query: the car connection state is now queried with an AsyncQueryHandler, off the main thread, like the Car App Library's CarConnection does. The broadcast only triggers a query.

3 s seek/pause after a takeover: it could seek and pause another video if one was opened within those 3 s. It now acts only if the current engine is the new page's (eng.getWebView() == webView). This also covers the existing restore from saved state on the phone.

Car testing: the disconnect pause and the takeover work in my car (switching off mid-video paused it, and reopening Fermata brought the video back). They haven't had extensive use yet.