Repository navigation
feat: store the Sigstore bundle with each Cosign signature - #66
Merged
Merged
Conversation
This was referenced Nov 5, 2026
muscariello
force-pushed
the
feat/cosign-bundle-referrer
branch
from
November 5, 2026 15:44
5897abe to
da8c956
Compare
muscariello
changed the base branch from
feat/trust-manifests-spec-117
to
feat/verify-command
November 5, 2026 15:44
muscariello
force-pushed
the
feat/cosign-bundle-referrer
branch
from
November 5, 2026 16:06
da8c956 to
6a0c48f
Compare
muscariello
force-pushed
the
feat/cosign-bundle-referrer
branch
from
November 5, 2026 17:23
6a0c48f to
d5ce617
Compare
muscariello
marked this pull request as ready for review
November 5, 2026 18:44
msardara
previously approved these changes
Nov 5, 2026
`cosign sign-blob --bundle` already writes a bundle, but only the raw signature was kept. Store the bundle as a second layer of the signature referrer, so verifiers can use `cosign verify-blob --bundle` instead of the deprecated `--signature`, and keep any log or timestamp evidence. Closes #64 Signed-off-by: Luca Muscariello <muscariello@ieee.org>
The signature referrer now stores the Cosign bundle, which keeps any timestamps requested at signing time. Refs #64 Signed-off-by: Luca Muscariello <muscariello@ieee.org>
muscariello
force-pushed
the
feat/cosign-bundle-referrer
branch
from
November 5, 2026 19:11
d5ce617 to
6d16f4f
Compare
lgecse
approved these changes
Nov 6, 2026
msardara
approved these changes
Nov 6, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack: #61 ← #65 ← #67 ← #66. Review and merge in that order; each PR shows only its own commits.
Closes #64. Needs Agent-Card/ai-catalog-rust#64, and Agent-Card/ai-catalog-rust#61 through #67.
Change
cosign sign-blob --bundlealready writes a Sigstore bundle; the CLI used to keep only the raw signature from it. It now passes both toattach_cosign_verification_artifacts_with_bundle, so the signature referrer has two layers:application/vnd.dev.sigstore.cosign.signature), unchanged, for existing consumers;application/vnd.dev.sigstore.bundle.v0.3+json).cosign verify-blob --bundle, and notes that offline-signed bundles also need--insecure-ignore-tlog=true.Dependencies
ai-catalog-rust 0.4.0 includes Agent-Card/ai-catalog-rust#61, #63 and #64, and #61 here is bumped to it, so this builds against released crates and CI passes.
Testing
Tested against the released 0.4.0 crates: 67 + 37 tests pass.
cargo testpasses, including a new assertion that the signature referrer's layers are[signature, bundle].cargo clippy --all-targets --all-features -- -D warningsandcargo fmt --checkpass.oci export-layout --cosign-keyon a two-manifest catalog stores both layers, andcosign verify-blob --key … --bundle <stored bundle> --insecure-ignore-tlog=true <payload>givesVerified OK.Timestamp note
Now that bundles are stored, the second commit removes #65's temporary
--sigstore-services tsanote and its README sentence: log entries and timestamps are kept in the stored bundle.