This repository was archived by the owner on Nov 3, 2026. It is now read-only.
Repository navigation
Keep the Transform class public - #932
Merged
Merged
Conversation
Transform went internal with the other SWIG types in 4.5.136, which stops a caller that uses it directly from moving past 4.5.125. This widens that one class back. The other generated types keep the visibility they have.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transformwentinternalin 4.5.136, when #831 made the SWIG types internal. A caller that usesTransformdirectly, to turn high entropy values or structured User-Agent evidence into headers, cannot compile against any package after 4.5.125 until it is public again.What changes
hash_csharp.ikeepsTransformpublic through acsclassmodifierstypemap.Interop/Swig/Transform.csmatches what SWIG then generates, which is one word on one line.This is the first commit of #912 by James Rogers, on its own, with its message and code comment reworded. The second commit of #912 pins the native code to a branch of device-detection-cxx#427, which closed when that work moved to 51degrees-cxx#20. There is no merged commit to re-point it at, as the review of #912 asked, so the native work reaches this package through the
cxxsubmodule instead.Version
This widens one class back to what it was in 4.5.125 and ships as the next patch. There is no
+semverdirective in the commit or here.What was checked
SWIG 4.3.0 was run over
hash_csharp.iwith and without the new line, against the 51degrees-cxx layout. Both runs finish with no error. Without the lineTransformisinternal, as onmain. With the lineTransformispublic, and the other 35 generated classes keep the visibility they had.The methods on
TransformreturnMapStringStringSwig, which is already public, so a publicTransformdoes not expose a less visible type.Not done
This has not been built or tested. The pull request build runs the tests when this is marked ready. If this has not merged when the .NET repositories move to their monorepo on 2 November, the two lines have to move with them, because the typemap lives in this repository's
hash_csharp.i.