From 7c18ff8741a1cbf46213cdd544cc7b780a59dec9 Mon Sep 17 00:00:00 2001 From: James Brink Date: Wed, 11 Nov 2026 18:50:32 -0700 Subject: [PATCH] fix(darwin): clear filterpy broken flag so macOS packages evaluate --- CHANGELOG.md | 5 +++++ nix/python-overrides.nix | 8 +++++++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4adcd28..44d45ef 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,6 +17,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ([#92](https://github.com/utensils/comfyui-nix/issues/92)) ### Fixed +- macOS packages evaluate again. The nixpkgs update in #119 marks filterpy + broken on Darwin because its tests crash there; our override already skips + those tests, so it now also clears the broken flag. Without this, every + `aarch64-darwin` output failed with `Refusing to evaluate package + 'python3.12-filterpy-2.0.0'`. - Apple Silicon comfy-kitchen operators use list annotations supported by PyTorch 2.5.1, preventing an import failure during operator registration. - Apple Silicon PyTorch shared-memory helpers close inherited resource-tracker diff --git a/nix/python-overrides.nix b/nix/python-overrides.nix index f73cde4..5275044 100644 --- a/nix/python-overrides.nix +++ b/nix/python-overrides.nix @@ -1123,10 +1123,16 @@ lib.optionalAttrs useCuda { }); } -# Disable filterpy tests on Darwin (test_hinfinity triggers BPT trap in pytest) +# Disable filterpy tests on Darwin (test_hinfinity triggers BPT trap in pytest). +# nixpkgs marks it broken on Darwin because Hydra's builds fail in those same +# tests ("last successful hydra build on darwin was in 2025"); with the tests +# skipped it builds, so clear the flag. facexlib (PuLID) depends on it. // lib.optionalAttrs (prev ? filterpy) { filterpy = prev.filterpy.overridePythonAttrs (old: { doCheck = if pkgs.stdenv.hostPlatform.isDarwin then false else (old.doCheck or true); + meta = (old.meta or { }) // { + broken = false; + }; }); }